More than 2 professions are not retained after log out and log in

Report issues that you found in the Legion repacks
Post Reply
stormdragon
Posts: 2

More than 2 professions are not retained after log out and log in

Post by stormdragon » Fri Jul 17, 2020 9:56 pm

I am not sure if this is an issue with this pack, or with TrinityCore/AshamaneCore. TrinityCore supports up to 11 via the MaxPrimaryTradeSkill. https://github.com/TrinityCore/TrinityCore/issues/15575

Background
When running our previous WOTLK 3.3.5a server, all player characters were able to learn all profession at the same time.





Reproduction Steps
  1. Ensure that worldserver.conf is set to MaxPrimaryTradeSkill = 11 (or anything above 2)
  2. Create a new character
  3. Learn any two professions (in one test I used Blacksmithing and Alchemy)
  4. -- Notice that you cannot manually learn a third profession from a trainer (Separate issue, I think)
  5. Manually learn the skill via GM Command .learn 7411 (Enchanting)
  6. /cast enchanting
  7. -- Notice how it works correctly
  8. -- Notice how in the DB the "character_skills" table has an entry for 333
  9. -- Another verify step, Disenchant an item, notice how your character_skills value for 333 correctly increases to 2
  10. -- Another verify step, run "/cast enchanting" Notice how the UI correctly shows a skill level of 2 for enchanting.
  11. Log out of the character
  12. -- Notice how in the DB the "character_skills" table has an entry for 333 with a value of 2
  13. Log in to the same character
  14. Wait ~1 minute for database to be updated
  15. ** Notice how in the DB the "character_skills" table no longer has an entry for 333
  16. -- Another verify step, "/cast enchanting", Notice how nothing happens
Expected Behavior: The worldserver should retain the character_skills of a player after logging off and logging in, especially if the config is setup to allow for more than 2.


Additional Details
  • Anticheat.Enable = 0 (Anti cheat is disabled)
  • No messages in the log files related to this, both client and server
  • (For Control) If enchanting is one of the two primary professions, and the steps above are followed, enchanting (333) works fine.
  • ?Clue? If you unlearn "Enchanting" as one of your two primary professions, (leaving one remaining) log off and log on, the same issue occurs " character_skills" will no longer have Enchanting 333.

Questions
- Is this is a problem with the SSP Legion pack or elsewhere in the stack.
- I have browsed the TrinityCore\AshamaneCore GitHub and cannot find the code that seems to remove the character_skills. "Player.cpp" looks like it might be a candidate, but cannot confirm.
- Does the GM command ".learn" miss an additional record/value needed for persistence with MaxPrimaryTradeSkill?


Internet Research
https://webcache.googleusercontent.com/ ... clnk&gl=us

https://community.trinitycore.org/topic ... ofessions/

https://github.com/TrinityCore/TrinityCore/issues/22903



stormdragon
Posts: 2

Re: More than 2 professions are not retained after log out and log in

Post by stormdragon » Sat Jul 18, 2020 5:02 pm


Post Reply